Skip to content

fix: remove the deprecated gomodguard linter - #294

Open
taran-p wants to merge 1 commit into
minio:mainfrom
taran-p:fix/gomodguard-v2
Open

taran-p wants to merge 1 commit into
minio:mainfrom
taran-p:fix/gomodguard-v2

Conversation

@taran-p

@taran-p taran-p commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

golangci-lint v2.12.0 deprecated gomodguard in favor of gomodguard_v2, and make lint warned about it on every run. The config never gave itallowed or blocked modules, so it checked nothing; drop it instead of migrating.

Summary by CodeRabbit

  • Chores
    • Updated the project’s linting configuration: one previously enabled lint check is no longer active. Other enabled lint checks remain unchanged. This change affects code-quality checks and does not alter application features or behavior.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The .golangci.yml configuration no longer enables gomodguard. The other enabled linters remain unchanged.

Changes: Linter configuration

Layer / File(s) Summary
Update enabled linters
.golangci.yml
The enabled linter list no longer includes gomodguard.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to d4aba

The narrowly scoped linter configuration change presents no identified merge-blocking risk and is ready to merge after normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the removal of the gomodguard linter from the configuration.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

I’m a rabbit; I hop by the linting list.
One name is gone; the rest still persist.
I twitch my nose and inspect the file.
The config looks neat, line by line.
Then I bound away with a quiet smile.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2811210d-41db-467e-8446-64c183ac446d
Commits

Reviewing files that changed from the base of the PR and between f76516c and d4aba77.

Files selected for processing: 1

  • .golangci.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

golangci-lint v2.12.0 deprecated gomodguard in favor of gomodguard_v2,
and make lint warned about it on every run. The config never gave it
allowed or blocked modules, so it checked nothing; drop it instead of
migrating.
@taran-p taran-p changed the title fix: switch gomodguard linter to gomodguard_v2 fix: remove the deprecated gomodguard linter Nov 3, 2026
@taran-p

taran-p commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant